chore(test): use vault.fullname in Helm test

hashicorp / vault-helm

Helm chart to install Vault and other associated components.

Mozilla Public License 2.0

1.06k stars 869 forks source link

chore(test): use vault.fullname in Helm test #912

Closed fty4 closed 11 months ago

fty4 commented 1 year ago

Currently the Helm chart does not use a consistent naming convention for the testing.

When running helm test myrelease a pod with name myrelease-server-test is created. There is no direct appearance that this is related to the vault chart in the name.

This PR changes the name to the same convention as other resources. The name then will be e.g. myrelease-vault-server-test.

Marco Lecheler marco.lecheler@mercedes-benz.com Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

fty4 commented 1 year ago

@tvoran I've just added tests for following usecases:

default metadata.name: release-name-vault-server-test
release metadata.name vault: vault-server-test
release metadata.name foo: foo-vault-server-test