search

hashicorp / vault-helm

Helm chart to install Vault and other associated components.
Mozilla Public License 2.0
1.08k stars 873 forks source link

Making Injector NetworkPolicy Namespace Scoped (#909) #922

Open amir-badar opened 1 year ago

amir-badar commented 1 year ago

909

hashicorp-cla commented 1 year ago

CLA assistant check
All committers have signed the CLA.

heatherezell commented 1 year ago

Hello @amir-badar - thank you for this submission! Can you let me know, was this a miss from the linked PR? Thanks!

amir-badar commented 1 year ago

@hsimon-hashicorp Is there a PR already raised for this issue? I can't see if you have put a reference link for that PR.

The problem which I have found is when you deploy this helm chart in a custom namespace it throws an error about Network Policy being missing for Namespace and as I have dig down i found that this object is not namespace scoped and so it throwing InvalidSpecError.

dlydiard commented 1 year ago

To give more context we are installing this chart with kustomize (helm enabled) + argo, so the namespace is required on the NetworkPolicy CR. The other injector charts seem to include the namespace, but it was missing for NetworkPolicy

amir-badar commented 1 year ago

@hsimon-hashicorp Do you have an ETA as to when this will be approved?