search

hashicorp / vault-helm

Helm chart to install Vault and other associated components.
Mozilla Public License 2.0
1.06k stars 869 forks source link

Adding long lived SA token option (#917) #923

Closed gillcaleb closed 11 months ago

gillcaleb commented 1 year ago

Addresses #917

The intent of this PR is to allow for the creation of a long-lived API token for the server SA.

hashicorp-cla commented 1 year ago

CLA assistant check
All committers have signed the CLA.

gillcaleb commented 12 months ago

It's unclear to my why the license/cla check continues to remain in a pending state as I've gone through the signing process and verified its completion on my end. I've tried re-checking it numerous times but to no avail.

hsimon-hashicorp commented 12 months ago

It's unclear to my why the license/cla check continues to remain in a pending state as I've gone through the signing process and verified its completion on my end. I've tried re-checking it numerous times but to no avail.

Usually that happens if your contributions are under a different account, ie, email. For example, I see that @stavvy-cgill is making the comments, but @gillcaleb is the commenter here. Try signing with your @stavvy-cgill account and that should fix it. Thanks!

stavvy-cgill commented 12 months ago

It's unclear to my why the license/cla check continues to remain in a pending state as I've gone through the signing process and verified its completion on my end. I've tried re-checking it numerous times but to no avail.

Usually that happens if your contributions are under a different account, ie, email. For example, I see that @stavvy-cgill is making the comments, but @gillcaleb is the commenter here. Try signing with your @stavvy-cgill account and that should fix it. Thanks!

Thank you!

gillcaleb commented 11 months ago

Hi team! Just wanted to check back in to get a sense for when this might get a review. Thanks!

gillcaleb commented 11 months ago

Thanks for raising this - I'm ok with adding it but I want to make sure Kubernetes' alternative recommendations are made clear. LGTM once a few naming and documentation comments are addressed. Thanks for including the tests and schema update too!

Appreciate the feedback! I went ahead and added the suggested changes.

kaibepperling commented 11 months ago

Thanks for opening the PR @gillcaleb! We ran in to the same thing today and were about to open a PR. Is anything blocking a release of that change?