hashicorp / vault-helm

Helm chart to install Vault and other associated components.
Mozilla Public License 2.0
1.05k stars 868 forks source link

openshift/server: readiness probe passes when server uninitialized #966

Closed tvoran closed 8 months ago

tvoran commented 8 months ago

Changes the default server readiness probe (just for openshift) to pass when the server is uninitialized, in order to pass the latest version of the chart-verifier test (see #954 for details).

Also updates the chart-verifier used in our tests to 1.13.0 (latest).

Testing against an OpenShift cluster:

$ go install github.com/redhat-certification/chart-verifier@1.13.0

$ chart-verifier verify ~/projects/vault-helm-review \
  --chart-values ~/projects/vault-helm-review/values.yaml \
  --chart-values ~/projects/vault-helm-review/values.openshift.yaml \
  --timeout 30s -e chart-testing
...
results:
    - check: v1.0/chart-testing
      type: Mandatory
      outcome: PASS
      reason: Chart tests have passed

Fixes #954

tvoran commented 8 months ago

Thanks!