Server side apply does not properly render volumeClaimTemplates

[thomaspetit]

Describe the bug Server side apply does not properly render volumeClaimTemplates. When rendering the Helm chart with server side apply we can see that the volumeClaimTemplates object (with datastorage enabled) renders the following:

  volumeClaimTemplates:
    - metadata:
        ...
      spec:
        accessModes:
          ...

While it should actually be the following

  volumeClaimTemplates:
    - apiVersion: v1
      kind: PersistentVolumeClaim
      metadata:
        ...
      spec:
        accessModes:
          ...

To Reproduce

1. Setup ArgoCD
2. Add Vault helm chart as an application
3. Enable datastorage on the Helm chart

Expected behavior Make the volumeClaimTemplate more explicit/declarative and thus eliminate possible errors when applying

Environment

• Kubernetes version: 1.27
• vault-helm version: 1.15.2

Chart values:

vault:
  controller:
    imagePullSecrets: []
  ui:
    enabled: true
  injector:
    enabled: false
  server:
    ingress:
      enabled: true
      hosts:
        - host: vault.foo.bar

Additional context

Issue was introduced with the following change: https://github.com/kubernetes/kubernetes/pull/87706

Good to know is that this issue is not new: https://github.com/argoproj/argo-cd/issues/11143 Other downstream applications nicely fixed this: https://github.com/vernemq/docker-vernemq/pull/347