hashicorp / vault-plugin-auth-kubernetes

Vault authentication plugin for Kubernetes Service Accounts
https://www.vaultproject.io/docs/auth/kubernetes.html
Mozilla Public License 2.0
206 stars 62 forks source link

Properly handle role.AliasNameSource migration #135

Closed benashz closed 2 years ago

benashz commented 2 years ago

133 details an issue where the role configuration cannot be updated when alias_name_source is unset in the request. The result was a validation failure for this field. We can handle this situation be setting the role's alias name source to be default.

Design of Change

How was this change implemented?

See above

Related Issues/Pull Requests

Closes #133 Relates to #134

Contributor Checklist

[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet My Docs PR Link Example [ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests) [ ] Backwards compatible