hashicorp / vault-plugin-auth-kubernetes

Vault authentication plugin for Kubernetes Service Accounts

https://www.vaultproject.io/docs/auth/kubernetes.html

Mozilla Public License 2.0

208 stars 61 forks source link

VAULT-2003 Consolidate jwt/jose to use just jwt lib #148

Closed swenson closed 2 years ago

swenson commented 2 years ago

Overview

Remove jose library direct dependency
Add additional integration tests to cover more cases
Switch to gofumpt to match vault

This mostly pays down technical debt and should hopefully make it easier to work with our JWT code moving forward.

This should cause minimal user-facing changes (notably there might be slight differences in the status code messages when signatures are invalid).

Related Issues/Pull Requests

30
33

Contributor Checklist

[x] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet (no user-facing changes made)
[x] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[x] Backwards compatible

calvn commented 2 years ago

This should also close https://github.com/hashicorp/vault-plugin-auth-kubernetes/issues/96

swenson commented 2 years ago

Thanks everyone!