search

hashicorp / vault-plugin-auth-kubernetes

Vault authentication plugin for Kubernetes Service Accounts
https://www.vaultproject.io/docs/auth/kubernetes.html
Mozilla Public License 2.0
206 stars 62 forks source link

fix role update endpoint and provide patch method #164

Open f4z3r opened 1 year ago

f4z3r commented 1 year ago

Overview

Fix the update endpoint for the role configuration to behave according to POST RESTful definitions. Add a PATCH endpoint for the role configuration.

This change might affect users that misuse the POST endpoints to update individual fields in the role configuration. If they omit required fields, this will now return an error, and if they simply omit fields, these will not be changed back to defaults (as opposed to keeping the value that was previously configured).

Design of Change

I reused most of the code that used to be the update function for the patch method (as it actually behaved like a patch). Also refactored some code into own methods to reduce code duplication.

Related Issues/Pull Requests

[ ] Issue #163 [ ] Vault PR #17371

Contributor Checklist

[x] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet Vault PR #17461 [ ] Backwards compatible

f4z3r commented 1 year ago

Hi @tvoran , is there anything else that you would want done in this PR?

f4z3r commented 11 months ago

Any update about this @tvoran ?