hashicorp / vault-plugin-auth-kubernetes

Vault authentication plugin for Kubernetes Service Accounts
https://www.vaultproject.io/docs/auth/kubernetes.html
Mozilla Public License 2.0
206 stars 62 forks source link

chore: add missing error checks #202

Closed thevilledev closed 1 year ago

thevilledev commented 1 year ago

Overview

If flag.Parse() fails now the error is hidden from the user. Adding the missing checks to tests just improve code quality.

Design of Change

Noticed an issue with CLI flag parsing. Fixed it first. Checked with errcheck linter if the codebase has other missing error checks.

Related Issues/Pull Requests

None

Contributor Checklist

[-] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet

None needed

[-] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)

None needed

[x] Backwards compatible