I think this code is wrong. As written, it modifies the config object instead of assigning the default issuer to the expected struct. I believe it means the first JWT validation in the lifespan of the process will fail, but subsequent validations will work.
Contributor Checklist
[X] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
This bug fix should be nearly invisible to the user.
[ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[X] Backwards compatible
Overview
I think this code is wrong. As written, it modifies the config object instead of assigning the default issuer to the
expectedstruct. I believe it means the first JWT validation in the lifespan of the process will fail, but subsequent validations will work.Contributor Checklist
[X] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet This bug fix should be nearly invisible to the user. [ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests) [X] Backwards compatible