search

hashicorp / vault-plugin-auth-kubernetes

Vault authentication plugin for Kubernetes Service Accounts
https://www.vaultproject.io/docs/auth/kubernetes.html
Mozilla Public License 2.0
209 stars 61 forks source link

Update jose v4 #248

Closed kpcraig closed 5 months ago

kpcraig commented 5 months ago

This is a short PR to update the go-jose library to v4 to avoid possible issues with v2 support, copying https://github.com/hashicorp/vault-plugin-auth-gcp/pull/203

It's possible v2.6.3 also fixes this issue (see https://github.com/go-jose/go-jose/releases/tag/v2.6.3), but this feels more future-proof (and the solution was readily available).

kpcraig commented 5 months ago

Sorry @benashz , i didn't see the review tag - if you want some more changes I can put them in before the release tag

benashz commented 5 months ago

@vinay-gopalan @kpcraig - yes, I am fairly certain these changes will break depending on the K8s API server config.