Open coryflucas opened 5 years ago
@coryflucas if you set up the config with terraform you can check if token_reviewer_jwt
is set in the state file
You should really just return the sha256 of the value so you can allow tools like terraform to fix drift. That will solve 99.9% of the use cases to get it from the config api endpoint
Currently since the read config endpoint does not expose the
token_reviewer_jwt
field for security reasons, but there is no indication if it is set or not. Because this field is optional, it doesn't seem to be possible to tell if its set other than trying to login with a kubernetes JWT that does not have access to the token reviewer API. It would be nice if the API returned thetoken_reviewer_jwt
masked, or just a field that indicate it was set (something liketoken_reviewer_jwt_provided
as a boolean).Happy to provide a PR if this is something you'd be interested in supporting.
Thanks for the great product!