search

hashicorp / vault-plugin-database-couchbase

Mozilla Public License 2.0
6 stars 5 forks source link

Fixed missing context based timeouts on WaitUntilReady method calls. #5

Closed fhitchen closed 4 years ago

fhitchen commented 4 years ago

Missed these two gocb WaitUntilReady client calls that had a short hard coded timeout set which were causing the flakiness in the automated tests.

tomhjp commented 4 years ago

Sorry I missed this PR for a while - thanks for raising it!

fhitchen commented 4 years ago

No worries. I want to finish the spring-cloud-vault integration now. I have it working but need to finish writing a test that uses this god awful @Annotations crap which is crazy confusing. I am stuck though as the build is broken as they have screwed up the Maven dependencies and I have to wait until that gets fixed.

fhitchen commented 4 years ago

Hi Tom,

Couchbase are keen to know when they can see the Vault documentation about their DB? Do you have any ETA on this that you can share with me?

I also need to test out their latest DB release, 6.5.1. See if they managed to break anything.

regards, Francis.

On Fri, Aug 7, 2020 at 9:55 AM Tom Proctor notifications@github.com wrote:

Merged #5 https://github.com/hashicorp/vault-plugin-database-couchbase/pull/5 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hashicorp/vault-plugin-database-couchbase/pull/5#event-3633584434, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABML24AOL5YBX3OW4PHG7PTR7QIXVANCNFSM4POE35CA .

tomhjp commented 4 years ago

Hi Francis, sorry I missed this before. The couchbase plugin is currently slated to be bundled with vault for release 1.6, so the website will be updated with the docs when that comes around, but I'm afraid I can't commit to a date for that.

The master branch already has the docs that will be published though, so feel free to review them and open any pull requests if there are improvements to be made.

On 6.5.1 - I was hoping there would be a server-sandbox 6.5.1 at some point, so we can just upgrade the version tested in CI. Seems like the versions are falling behind a bit there though.

fhitchen commented 3 years ago

Hi Tom,

One of my customers is a big Vault & Redis user, so for giggles I thought I would see how difficult it was to write a plugin for Redis. I picked one of the recommended Redis SDK's and it turned out to be quite simple. Would you be interested in taking a look at it, https://github.com/fhitchen/vault-plugin-database-redis?

Redis is not typically used in situations where TLS is enabled for performance reasons, so I think I need to look at pumping up the length of the generated passwords. Also Redis has another security feature where the configuration commands can be obfuscated. I want to see if there is a way that Vault can obfuscate and control those commands.

regards, Francis.

On Mon, Sep 7, 2020 at 11:04 AM Tom Proctor notifications@github.com wrote:

Hi Francis, sorry I missed this before. The couchbase plugin is currently slated to be bundled with vault for release 1.6, so the website will be updated with the docs when that comes around, but I'm afraid I can't commit to a date for that.

The master branch already has the docs that will be published though, so feel free to review them and open any pull requests if there are improvements to be made.

On 6.5.1 - I was hoping there would be a server-sandbox 6.5.1 at some point, so we can just upgrade the version tested in CI. Seems like the versions are falling behind a bit there though.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hashicorp/vault-plugin-database-couchbase/pull/5#issuecomment-688411885, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABML24HUVNROV6QHNUNUU73SET77BANCNFSM4POE35CA .

tomhjp commented 3 years ago

Hi Francis - this looks pretty cool! You're very welcome to open an issue or PR to get it included in our plugin portal's community section if you'd like that. I think there will definitely be some people interested in it.

Interesting to hear about TLS. I'm not familiar with Redis so it may just be because I don't know the deployment model but it does seem odd to require username/password but not TLS.