Improve error handling around unassignment of non-existent role assignment ID
Better error handling in test, and guarding against nil or empty values
Add clarity to rollback log message, and check if there were no Azure Roles associated with Role
Further improve error handling, fix failing test, add guard against size mismatch between number of roles and assignmentIDs, parameterize Resource Group in test
Fix rollback test, and clean up left over debug line
Add missing error check for spRevoke during test, use errors.New instead of Errorf for AzureRoles and assignmentIDs check
Add warning about resources potentially still existing if WAL has expired
Overview
A high level description of the contribution, including:
Who the change affects or is for (stakeholders)?
What is the change?
Why is the change needed?
How does this change affect the user experience (if at all)?
[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR LinkExample
[ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[ ] Backwards compatible
Implement Role Assignment WAL and rollback
Improve error handling around unassignment of non-existent role assignment ID
Better error handling in test, and guarding against nil or empty values
Add clarity to rollback log message, and check if there were no Azure Roles associated with Role
Further improve error handling, fix failing test, add guard against size mismatch between number of roles and assignmentIDs, parameterize Resource Group in test
Fix rollback test, and clean up left over debug line
Add missing error check for spRevoke during test, use errors.New instead of Errorf for AzureRoles and assignmentIDs check
Add warning about resources potentially still existing if WAL has expired
Overview
A high level description of the contribution, including: Who the change affects or is for (stakeholders)? What is the change? Why is the change needed? How does this change affect the user experience (if at all)?
Design of Change
How was this change implemented?
Related Issues/Pull Requests
[ ] Issue #1234 [ ] PR #1234
Contributor Checklist
[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet My Docs PR Link Example [ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests) [ ] Backwards compatible