hashicorp / vault-plugin-secrets-azure

Vault Azure Secrets plugin
Mozilla Public License 2.0
26 stars 19 forks source link

deprecated packages from github.com/Azure/azure-sdk-for-go have been removed #143

Open srenatus opened 1 year ago

srenatus commented 1 year ago

With the v68.0 release of github.com/Azure/azure-sdk-for-go, the authorization package disappeared.

Before that, for example in v67.4.0, we could find a deprecation comment saying

Please note, this package has been deprecated. A replacement package is available github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/authorization/armauthorization. We strongly encourage you to upgrade to continue receiving updates. See Migration Guide for guidance on upgrading. Refer to our deprecation policy for more details.

Users of this module, or any other module that depends on it, are blocked from upgrading the azure module:

go: finding module for package github.com/Azure/azure-sdk-for-go/services/preview/authorization/mgmt/2018-01-01-preview/authorization
github.com/styrainc/xxx/e2e/yyy tested by
    github.com/styrainc/xxx/e2e/yyy.test imports
    github.com/hashicorp/vault/vault tested by
    github.com/hashicorp/vault/vault.test imports
    github.com/hashicorp/vault/helper/builtinplugins imports
    github.com/hashicorp/vault-plugin-secrets-azure imports
    github.com/Azure/azure-sdk-for-go/services/preview/authorization/mgmt/2018-01-01-preview/authorization: module github.com/Azure/azure-sdk-for-go@latest found (v68.0.0+incompatible), but does not contain package github.com/Azure/azure-sdk-for-go/services/preview/authorization/mgmt/2018-01-01-preview/authorization
StyraInc/load-private % git grep  github.com/Azure/azure-sdk-for-go/services/preview/authorization/mgmt/2018-01-01-preview/authorization

I guess the only way out is to follow the migration guide and switch packages...? Is this on anyone's radar already? (I couldn't find any related issues...)

Thank you! 🎈

remiphilippe commented 1 year ago

I have a fix for this repo here that I can PR - https://github.com/remiphilippe/vault-plugin-secrets-azure/tree/azure-permissions-fix

But there is the same problem in https://github.com/hashicorp/vault-plugin-auth-azure/

remiphilippe commented 1 year ago

cc @vinay-gopalan which seems to be working on a fix https://github.com/hashicorp/vault-plugin-auth-azure/pull/107

austingebauer commented 1 year ago

@srenatus @remiphilippe - We're working on migrating both Azure secrets and auth. Will keep you updated here as that progresses.