The error handling case in unassignRoles was misconstrued, and was causing a panic when unassigning role assignments would fail during a WAL Rollback. This PR appropriately parses the received error from Azure and fixes the if cases to remove the panic case.
A unit test with a mock provider was added to confirm that the plugin can correctly
return errors when needed
ignore errors if the status code is 204 or 404 (role assignment was manually deleted)
Related Issues/Pull Requests
[x] [Issue #190]
[x] [PR #210]
Contributor Checklist
[x] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR LinkExample
[x] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[x] Backwards compatible
Overview
The error handling case in
unassignRoles
was misconstrued, and was causing a panic when unassigning role assignments would fail during a WAL Rollback. This PR appropriately parses the received error from Azure and fixes the if cases to remove the panic case.A unit test with a mock provider was added to confirm that the plugin can correctly
Related Issues/Pull Requests
[x] [Issue #190] [x] [PR #210]
Contributor Checklist
[x] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet My Docs PR Link Example [x] Add output for any tests not ran in CI to the PR description (eg, acceptance tests) [x] Backwards compatible
test output without fix:
test output with fix: