hashicorp / vault-plugin-secrets-mongodbatlas

Mozilla Public License 2.0
5 stars 3 forks source link

Vendoring vault fails; needs latest github.com/mongodb/go-client-mongodb-atlas #11

Closed countingtoten closed 2 years ago

countingtoten commented 4 years ago

Describe the bug A package github.com/mwielbut/pointy was renamed to github.com/openlyinc/pointy and is causing vendoring issues. github.com/mwielbut/pointy is a dependency of github.com/mongodb/go-client-mongodb-atlas. Updating to the latest version of mongodb/go-client-mongodb-atlas should fix the issue.

To Reproduce Steps to reproduce the behavior:

  1. Start from a clean working environment. Run docker run -it golang:latest
  2. Run GO111MODULE=on go get -u github.com/hashicorp/vault@v1.4.3
  3. See error
    go get: github.com/mwielbut/pointy@v1.1.0 updating to
    github.com/mwielbut/pointy@v1.1.2: parsing go.mod:
    module declares its path as: github.com/openlyinc/pointy
            but was required as: github.com/mwielbut/pointy

Expected behavior The vault module should vendor without error

Environment:

Additional context Add any other context about the problem here.

kalafut commented 4 years ago

Thank for reporting this, and I'm seeing the same in a clean environment.

swenson commented 2 years ago

It looks like we no longer depend directly on this, and in Go 1.17+, this seems to vendor cleanly.

However, there were some similar, related vendoring issues with go get that were still present, so I cleaned those up in https://github.com/hashicorp/vault/pull/15093 (and updated go-client-mongodb-atlas too :)

Thanks for the report!