hashicorp / vault-rails

A Rails plugin for easily integrating Vault secrets
Mozilla Public License 2.0
339 stars 53 forks source link

Loosen dependency to only ActiveSupport #114

Closed chrisarcand closed 3 years ago

chrisarcand commented 3 years ago

Description

This gem utilizes ActiveSupport, specifically, and doesn't need to have a hard dependency on the 'rails' metagem itself.

This is a topical change at the moment with https://github.com/rails/rails/issues/41750; if an application does not use ActiveStorage and ActionMailbox, it may choose specifically include the Rails components it needs instead of rails itself to avoid installing the mimemagic gem. Even if you aren't actually using the mimemagic functionality, transient dependencies - like this gem - must also not require it.

As this gem doesn't require anything other than ActiveSupport, we'll loosen constraints this gem imposes.