hashicorp / vault-secrets-operator

The Vault Secrets Operator (VSO) allows Pods to consume Vault secrets natively from Kubernetes Secrets.
https://hashicorp.com
Other
471 stars 102 forks source link

Fix: encryption client deadlocking the factory #868

Closed benashz closed 3 months ago

benashz commented 4 months ago

Setting up the storage encryption client deadlocks the client factory if the client is deemed to be invalid. This causes all reconciliations to block forever.

The fix is to move the client setup code out of storageEncryptionClient(). This gets rid of the vestigial recursive call to itself and allows for single locker.