search

hashicorp / vault-secrets-operator

The Vault Secrets Operator (VSO) allows Pods to consume Vault secrets natively from Kubernetes Secrets.
https://hashicorp.com
Other
471 stars 102 forks source link

Allow some extra labels for controller Deployment installed by the Helm chart #955

Open sebastien-prudhomme opened 4 weeks ago

sebastien-prudhomme commented 4 weeks ago

Is your feature request related to a problem? Please describe.

The chart doesn't allow setting extra labels on the controller Deployment or more generally doesn't allow to add some common labels to all ressources. I need it to monitor the application and set some metadata for better management of monitoring alerts.

Describe the solution you'd like

Either fix the chart to also apply "controller.extraLabels" value to the Deployment or add a new "controller.extraDeploymentLabels" value.

Same thing should be done for annotations.

Describe alternatives you've considered

Doing a "kubectl label" after applying the chart

satyamkapoor commented 2 weeks ago

Hi @sebastien-prudhomme, do you specifically mean that the upgrade CRD hook doesn't includes an option of deploying extraLabels?

The chart does use controller.extraDeploymentLabels for deployment but not for the crd upgrade job pod -> helm template vso hashicorp/vault-secrets-operator --set controller.extraLabels.mylabelname=mylabelvalue | grep -A 40 "kind: Deployment"