search

hashicorp / vault

A tool for secrets management, encryption as a service, and privileged access management
https://www.vaultproject.io/
Other
31.06k stars 4.2k forks source link

Current module relies on retracted release of library https://github.com/hashicorp/go-msgpack #18690

Open blainenelson opened 1 year ago

blainenelson commented 1 year ago

Describe the bug

Currently this package uses github.com/hashicorp/go-msgpack v1.1.5 in it's go.mod as a dependency. github.com/hashicorp/go-msgpack v1.1.5 was retracted by author:

https://github.com/hashicorp/go-msgpack/releases/tag/v1.1.6

Using 1.1.5 or the earlier version 0.5.5 of this package leads to using an earlier version of the library

https://github.com/shirou/gopsutil

which includes deprecated MacOS primatives in MacOS 12.0+

# github.com/shirou/gopsutil/disk
iostat_darwin.c:28:2: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:132:1: note: 'IOMasterPort' has been explicitly marked deprecated here
# github.com/shirou/gopsutil/host
smc_darwin.c:75:41: warning: 'kIOMasterPortDefault' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:123:19: note: 'kIOMasterPortDefault' has been explicitly marked deprecated here

which are resolved in more recent versions of the library:

https://github.com/shirou/gopsutil/issues/1164 https://github.com/shirou/gopsutil/pull/1191

This issue would be resolved if this module depended on github.com/hashicorp/go-msgpack v2.0.0 or higher.

To Reproduce

Warnings as mentioned above result from imports such as

import (
    vaultapi "github.com/hashicorp/vault/api"
    vaultcore "github.com/hashicorp/vault/vault"
)

on MacOS 12.0 or higher.

Expected behavior

Please migrate to using the latest version github.com/hashicorp/go-msgpack v2.0.0 or higher.

Environment:

Vault server configuration file(s):

# Paste your Vault config here.
# Be sure to scrub any sensitive values

Additional context Add any other context about the problem here.

heatherezell commented 1 year ago

Hi there - it's been a while since you filed this issue. I apologize about the delay. Our engineering team is working on this, but with such impactful changes as this would necessitate, we want to be very sure not to create further problems especially for other products that may also use go-msgpack. I apologize I can't give a better update for you right now, but please know I'll follow up with our product and engineering teams to ensure this doesn't fall by the wayside - and I appreciate your patience!