hashicorp / vault

A tool for secrets management, encryption as a service, and privileged access management
https://www.vaultproject.io/
Other
30.79k stars 4.17k forks source link

api: drop dependency on go-rootcerts #26136

Open dolmen opened 5 months ago

dolmen commented 5 months ago

The github.com/hashicorp/go-rootcerts module doesn't seem necessary anymore with recent Go versions:

$ cd api
$ go mod graph | grep go-rootcerts          
github.com/hashicorp/vault/api github.com/hashicorp/go-rootcerts@v1.0.2
github.com/hashicorp/go-rootcerts@v1.0.2 github.com/mitchellh/go-homedir@v1.1.0
github.com/hashicorp/vault/api@v1.0.5-0.20200519221902-385fac77e20f github.com/hashicorp/go-rootcerts@v1.0.1
github.com/hashicorp/go-rootcerts@v1.0.1 github.com/mitchellh/go-homedir@v1.1.0
$ go mod graph | grep go-homedir  
github.com/hashicorp/go-rootcerts@v1.0.2 github.com/mitchellh/go-homedir@v1.1.0
github.com/hashicorp/go-rootcerts@v1.0.1 github.com/mitchellh/go-homedir@v1.1.0 
dolmen commented 1 month ago

There are only a few references to rootcerts.Config in this repo:

If I write the patch myself, is there a chance for it to be accepted?