hashicorp / vault

A tool for secrets management, encryption as a service, and privileged access management
https://www.vaultproject.io/
Other
31.34k stars 4.23k forks source link

Secret Engine Metrics - Database telemetry is missing #8858

Open iusergii opened 4 years ago

iusergii commented 4 years ago

Describe the bug Telemetry for Database Secret Engine is absent.

To Reproduce

Expected behavior Get metrics mentioned in secrets-engines-metrics

Environment:

vault status
Key                      Value
---                      -----
Recovery Seal Type       shamir
Initialized              true
Sealed                   false
Total Recovery Shares    5
Threshold                3
Version                  1.2.4
...

Vault server configuration file(s):

disable_mlock = true
ui = true

listener "tcp" {
  tls_disable = 1
  address = "[::]:8200"
  cluster_address = "[::]:8201"
}

storage "dynamodb" {
  ha_enabled = 1
  table = "vault-dev"
}

log_level = "Info"
log_format = "standard"

telemetry {
  prometheus_retention_time = "30s",
  disable_hostname = true
}

Additional context

curl -X Get -H "X-Vault-Token:s."  https://vault.com/v1/sys/mounts | jq  '.["database/"]'
{
  "accessor": "database_512ee413",
  "config": {
    "audit_non_hmac_response_keys": [
      "username"
    ],
    "default_lease_ttl": 2678400,
    "force_no_cache": false,
    "max_lease_ttl": 31536000
  },
  "description": "Databases",
  "local": false,
  "options": null,
  "seal_wrap": false,
  "type": "database",
  "uuid": "b45ea8d9-34e7-93ce-634d-516a56a5ac66"
}
iusergii commented 4 years ago

Checked on v1.4.2 - don't see database metrics. @calvn Am I looking in wrong place?

iusergii commented 4 years ago

Duplicated in discussion forum

TamasNeumer commented 3 years ago

For me they (suddenly) popped up... Well at least part of them. For example I have vault_route_revoke_xxx_database_postgres__count, however I would have been interested in the database.RevokeUser.error. The labels exposed (Time, name, cluster, instance, job, prometheus,Value) don't have the necessary info.