search

hashicorp / vault

A tool for secrets management, encryption as a service, and privileged access management
https://www.vaultproject.io/
Other
30.88k stars 4.18k forks source link

Fatal plugin crashes not logged normally - wrong log level #9290

Open universam1 opened 4 years ago

universam1 commented 4 years ago

Describe the bug When plugin crash this information is not forwarded to the standard log level. For operators there is no indication that a fatal issue happened.

It requires "DEBUG" log level being enabled to see relevant logs, which is terrible for production systems

To Reproduce Steps to reproduce the behavior:

  1. Let the plugin crash, no error logged just a warning [WARN] error closing client during Kill: err="rpc error: code = Canceled desc = grpc: the client connection is closing"
  2. enable "debug" log level, now ERROR is logged like [DEBUG] panic: runtime error: invalid memory address or nil pointer dereference

Expected behavior Panics and such are not "debug" but "error" log level

Environment:

ShacharN commented 2 years ago

@ncabatoff any updates on this topic?

heatherezell commented 5 months ago

Hello! Does this issue still exist in newer versions of vault? Please let me know. Thanks!