hashicorp / vscode-terraform

HashiCorp Terraform VSCode extension
https://marketplace.visualstudio.com/items?itemName=HashiCorp.terraform
Mozilla Public License 2.0
918 stars 178 forks source link

Extension does not support unquoted values allowed in 0.12 #180

Closed kohenchia closed 4 years ago

kohenchia commented 5 years ago

The VSCode extension gives me an error for the following syntax:

variable foo {
  type = string
         ^^^^^^

It expects "string", but the unquoted form is supported in the official docs for 0.12.

The extension also gives me an error for the following syntax:

locals {
  xyz = "abc"
}

module "src" {
  name = local.xyz
         ^^^^^^^^^
} 

It expects the quoted form "local.xyz", but the unquoted form is supported in the official docs for 0.12.

MattFenner commented 5 years ago

I might have a go at the first part tomorrow (supporting unquoted types). I have never contributed to open source before, so it may take me a little bit to figure it out.

Any advice is appreciated.

edit: actually, after looking some more it seems to be a much bigger task than I thought. It seems to be part of a much bigger task to support hcl2 and terraform 0.12 ( #157 ) . I think this is above my knowledge level, so i am going to have to bow out for now.

mauve commented 5 years ago

the plugin does not yet support 0.12 syntax correctly, both the tmLanguage files need updating as well as the indexing/parsing, refer to https://github.com/mauve/vscode-terraform/issues/157 for information.

On Fri, May 31, 2019 at 2:20 PM Matt Fenner notifications@github.com wrote:

I might have a go at the first part tomorrow (supporting unquoted types). I have never contributed to open source before, so it may take me a little bit to figure it out.

Any advice is appreciated.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

MattFenner commented 5 years ago

FYI I have updated the tmLanguage files so at least the highlighting looks right. You will still get errors until #157 is fixed though.

paultyng commented 4 years ago

We just released v2.0.0-rc.1 of the extension. The main features include:

You can find additional information and specifics in the release notes and CHANGELOG.

With this release we expect that many of the prior issues and PRs are no longer relevant or have been addressed, and are therefore being closed. If you feel the action taken on an issue or PR is in error, please comment as such and we can figure out the appropriate way to address it.

We plan to add the final 2.0.0 release to the marketplace soon, but are actively seeking your feedback now on the release candidates. You can download the .vsix from the releases page and manually install it in VS Code to try it out.

ghost commented 4 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.