hashicorp / waypoint-helm

Helm chart to install Waypoint and other associated components.
Mozilla Public License 2.0
29 stars 14 forks source link

`helm uninstall` appears to not remove the old server context #19

Closed krantzinator closed 2 years ago

krantzinator commented 2 years ago

Describe the bug helm uninstall appears to not remove the old server context, which waypoint uninstall does by default, or cleanup other k8s resources that will then block a new install.

Steps to Reproduce

The k8s cluster will still be using the old server context, and so the runner will not be able to start.

$ kubectl logs pod/waypoint-runner-894d94fd4-h4rrt
Error from server (BadRequest): container "waypoint" in pod "waypoint-runner-894d94fd4-h4rrt" is waiting to start: PodInitializing

$ kubectl logs pod/waypoint-server-0
...
2021-11-09T17:36:16.992Z [INFO]  waypoint.server.grpc: /hashicorp.waypoint.Waypoint/BootstrapToken request
2021-11-09T17:36:16.992Z [INFO]  waypoint.server.grpc: /hashicorp.waypoint.Waypoint/BootstrapToken response: error="rpc error: code = PermissionDenied desc = server is already bootstrapped" duration=109.281µs

If you delete the context manually, you don't even get that far:

$ kubectl logs pod/waypoint-server-0
Error from server: Get "https://[IP]:[port]/containerLogs/default/waypoint-server-0/waypoint": EOF

Expected behavior I would expect helm uninstall to mirror waypoint uninstall as usefully as possible.

Alternatively, our documentation can include the specific instructions in our Upgrade and Uninstall guides that are unique to helm.

Waypoint Platform Versions waypoint version: full_string="v0.6.2 (99350730+CHANGES)" version=v0.6.2

mitchellh commented 2 years ago

This won't be possible, since Helm can't do anything on your local machine. Similarly, we don't setup the local context on helm install either. You have to manually run the waypoint login command to do that. We could potentially introduce a waypoint logout command though instead?