hashicorp / waypoint-helm

Helm chart to install Waypoint and other associated components.
Mozilla Public License 2.0
29 stars 14 forks source link

Ability to customize 'waypoint server run' options #7

Closed nkkowa closed 3 years ago

nkkowa commented 3 years ago

Is your feature request related to a problem? Please describe. Unable to pass options to waypoint server run command.

Describe the solution you'd like I'd like to be able to change the options passed to the command defined in server-statefulset.yaml, as there are a lot of options that can be configured. https://www.waypointproject.io/commands/server-run

For us, we want to set -url-auto-app-hostname to false, and disable the insecure HTTP listener.

Describe alternatives you've considered Manually setting up the service

Explain any additional use-cases Depending on ones use-case they may want to customize various run options.

Additional context N/A

izaaklauer commented 3 years ago

Do you mean the waypoint server install command? server run allows you to disable the url service: https://www.waypointproject.io/commands/server-run#url-enabled

That flag can also be passed into the server install command after a --, i.e. waypoint install -platform=kubernetes -accept-tos -- -url-enabled=false : https://www.waypointproject.io/commands/server-install#usage

mitchellh commented 3 years ago

I think the issue is the Helm chart doesn't allow any custom options to server run in the statefulset. We absolutely need to expose that, probably just as an array you can set that we append onto our default options, because I believe conflicting options last-write-wins so customized options someone could always overwrite.

nkkowa commented 3 years ago

I think the issue is the Helm chart doesn't allow any custom options to server run in the statefulset. We absolutely need to expose that, probably just as an array you can set that we append onto our default options, because I believe conflicting options last-write-wins so customized options someone could always overwrite.

Yep, that would be perfect!