search

hashicorp / waypoint

A tool to build, deploy, and release any application on any platform.
https://waypointproject.io
Other
4.76k stars 327 forks source link

Protect ourselves against clean-css misfires #2382

Closed jgwhite closed 2 years ago

jgwhite commented 3 years ago

What’s the bug? It’s possible for clean-css to misfire and produce incorrect optimized CSS, as in #2376.

What should we do about it? We need to investigate a little more, but here’s what we’ve discussed so far:

  1. ~Upgrade clean-css~ — this is rather involved, we’d have to take over maintenance of broccoli-clean-css and perform a chain of major version upgrades
  2. Disable clean-css — we’ll first have to determine if the filesize trade-off is acceptable
  3. Disable a specific clean-css optimization — this will probably involve a lot of hunting around, and we still might running into bugs we’re not yet aware of
jgwhite commented 3 years ago
  1. Recruit Percy to help us catch things by enabling minifyCSS in the test env
gregone commented 3 years ago

there was a very possibly related bug in clean-css that was fixed in 3.3.0. Broccoli-clean-css is stuck on 3.1.x I think the upgrade, although involved, would be a big benefit for the ember ecosystem

jgwhite commented 2 years ago

In the end we chose option 4 👍