Closed acaloiaro closed 1 year ago
Hey @acaloiaro - this is a good thing to call out. I think we could at least solve this by adding some warnings in our documentation around using the nomad jobpsec plugin. A nice to have would be showing a warning in Waypoint when we detect that the nomad jobpsec file has configured an entrypoint which would conflict with Waypoints entrypoint. Anyway, thanks for the request!
I think that'd be a great middle ground solution @briancain. Thanks.
This appears complete.
Describe the bug When waypoint's entrypoint is enabled with a Nomad jobspec task, the Nomad docker driver's
config.entrypoint
cannot be set, lest it override Waypoint entrypoint injection.While I understand if the project maintainers would prefer not to label this a bug, I believe it's worth noting that the result is quite surprising. That is, a task that successfully launches without any of the benefits of a waypoint entrypoint e.g. environment variables set with waypoint are not available,
waypoint exec
is unavailable, etc.A warning would be nice, or a mention in the documentation about waypoint configuration settings that conflict with nomad jobspec configurations. Perhaps here: https://www.waypointproject.io/plugins/nomad#entrypoint-functionality
Steps to Reproduce
config.entrypoint
to anythingExpected behavior A. That this behavior is documented or B. That the waypoint-injected entrypoint launch the entrypoint specified by
config.entrypoint
Waypoint Platform Versions Additional version and platform information to help triage the issue if applicable:
Additional context