search

hashicorp / waypoint

A tool to build, deploy, and release any application on any platform.
https://waypointproject.io
Other
4.76k stars 327 forks source link

Make Registry Stanza required for Build #3328

Open briancain opened 2 years ago

briancain commented 2 years ago

Describe the bug

If a user tries Waypoint with a remote project backed by git, they often run into a situation where they get a huge arg-mapper error saying they're missing docker.AccessInfo. This is because in a remote context, we require a registry so that Kaniko can push the built artifact outside of the container it was built in.

Given that remote projects are our general suggestion for using Waypoint, we should flip this behavior. Instead, we should make a registry stanza required, which is the happy path, and require that folks opt-out of using it if they so choose and want to use the docker plugin and push locally.

Steps to Reproduce

https://github.com/hashicorp/waypoint/issues/3314

Run a Waypoint project in a remote context without a registry stanza.

Expected behavior

Users should get feedback that they are missing a required stanza registry before they get to the point that waypoint is trying to build their project.

Waypoint Platform Versions

Any

Additional context Add any other context about the problem here.

mitchellh commented 2 years ago

Users can "opt out" by us introducing a null registry. This would just pass through the artifact without doing anything. Just an idea (that maybe you discussed) rather than introducing any other special opt out flag.