hashicorp / waypoint

A tool to build, deploy, and release any application on any platform.
https://waypointproject.io
Other
4.76k stars 326 forks source link

Azure ACI: Does not Destroy #4787

Open F0otsh0T opened 1 year ago

F0otsh0T commented 1 year ago

Describe the bug waypoint destroy does not remove the Azure resources created via Waypoint

Steps to Reproduce Using Waypoint Tutorial to spin up an Application on Azure, I was able to spin up the Container in Azure after Joe Rajewski made some changes on the Auth as documented in this Issue @ this PR. When it came time to waypoint destroy, it never removed the Azure resources (Containers) created in the Tutorial.

I asked Joe Rajewski about this and his quote:

"just took a quick look through the code. it looks like the Destroyer interface of the plugin SDK isn't implemented for the Azure ACI plugin"

"That's a bit more work than the fix for the auth, so the team will need to prioritize that in the backlog - could you make a GitHub issue on hashicorp/waypoint about this (adding destroy functionality to the Azure ACI plugin)?"

Please include any waypoint.hcl files if applicable, as well as a GitHub Gist of any relevant logs or steps to reproduce the bug. Running waypoint commands with -v up to -vvv will include any additional debugging info in the log.

Expected behavior waypoint destroy with Azure ACI should destroy the resources created from waypoint up

Waypoint Platform Versions Additional version and platform information to help triage the issue if applicable:

Additional context Add any other context about the problem here.

cicoyle commented 1 year ago

Hey @F0otsh0T, thanks for documenting this. It looks like we might've missed adding the destroy functionality to this plugin upon our initial implementation of waypoint destroy like Joe said.