hashicorp / waypoint

A tool to build, deploy, and release any application on any platform.
https://waypointproject.io
Other
4.76k stars 327 forks source link

Tutorials are not complete: Tagging Docker image: nomad-nodejs-web:latest Error parsing reference #4889

Open EugenKon opened 1 year ago

EugenKon commented 1 year ago

Nomad version

$ nomad -v Nomad v1.6.1 BuildDate 2023-07-21T13:49:42Z Revision 515895c7690cdc72278018dc5dc58aca41204ccc

Issue

$ waypoint up

» Performing operation locally

» Building nomad-nodejs-web...
✓ Running build v1
Creating new buildpack-based image using builder: heroku/buildpacks:20
✓ Creating pack client
✓ Building image
 │ [exporter] Adding layer 'buildpacksio/lifecycle:process-types'
 │ [exporter] Adding label 'io.buildpacks.lifecycle.metadata'
 │ [exporter] Adding label 'io.buildpacks.build.metadata'
 │ [exporter] Adding label 'io.buildpacks.project.metadata'
 │ [exporter] Setting default process type 'web'
 │ [exporter] Saving nomad-nodejs-web...
 │ [exporter] *** Images (26894be156a6):
 │ [exporter]       nomad-nodejs-web
 │ [exporter] Adding cache layer 'heroku/nodejs-engine:dist'
 │ [exporter] Adding cache layer 'heroku/nodejs-npm:toolbox'
✓ Injecting entrypoint binary to image

Generated new Docker image: nomad-nodejs-web:latest
✓ Running push build v1
❌ Tagging Docker image: nomad-nodejs-web:latest => /nomad-nodejs-web:1
! unable to tag image:Error parsing reference: "/nomad-nodejs-web:1" is not a
  valid repository/tag: invalid reference format

Reproduction steps

Follow self managed nomad https://developer.hashicorp.com/waypoint/tutorials/get-started-nomad-cloud/get-started-nomad-cloud

Expected Result

Successful deployment

Actual Result

Deployment failed

EugenKon commented 1 year ago

Found an issue. I updated this names to actual values

variable "registry_username" {
  type = string
  default = ""
  env = ["REGISTRY_USERNAME"]
}

variable "registry_password" {
  type = string
  sensitive = true
  default = ""
  env = ["REGISTRY_PASSWORD"]
}

This is ambigious. Sometimes you require to update (learn-nomad-cluster-setup/aws/variables.hcl), sometimes not (like here). This is ambigous. =(

tgross commented 1 year ago

Hi @EugenKon I'm going to transfer this issue over to the Waypoint repo, as the folks there will have better context on how to help you out.