wait for both recv and send routines to complete on close

hashicorp / yamux

Golang connection multiplexing library

Mozilla Public License 2.0

2.19k stars 232 forks source link

wait for both recv and send routines to complete on close #105

Closed clems4ever closed 2 years ago

clems4ever commented 2 years ago

this change ensures that there is no write operations after close is called. This was not the case before and this led to race conditions in the caller code because there was no way to ensure there would not be any write anymore after the close.

jefferai commented 2 years ago

Looks good -- can you fix the conflicts? Thanks!

jefferai commented 2 years ago

I did a local conflict resolution but after doing so I'm seeing a failing test.

jefferai commented 2 years ago

The failing test actually turned out to be the same underlying problem as #77 !

I've updated the test and it passes.

jefferai commented 2 years ago

Looks good, thanks!

clems4ever commented 2 years ago

Awesome thanks!