search

hashicorp / yamux

Golang connection multiplexing library
Mozilla Public License 2.0
2.25k stars 236 forks source link

Yamux should not log errors #42

Closed jeffreydwalter closed 8 years ago

jeffreydwalter commented 8 years ago

Having Yamux log errors means that software that uses this library have no real control over what messages are logged where. Since Yamux is already returning named errors, which basically contain the message being logged, it would be much nicer if that error could be handled at a higher level and logged there.

jeffreydwalter commented 8 years ago

Nevermind, I didn't see Session had a flag for that.