search

hashicorp / yamux

Golang connection multiplexing library
Mozilla Public License 2.0
2.23k stars 235 forks source link

Add public session CloseChan method #44

Closed r0l1 closed 6 years ago

r0l1 commented 7 years ago

I commonly use the following style to wait until a connection closes to handle further cleanup...

go func() {
    <-session.CloseChan()
    // Do some cleanup, close other parent connections...
}()

Would be great to see this feature upstream.

pjvds commented 7 years ago

Is there any reason not to pull this one? We've made the same change upstream and I'm looking forward to see this one pulled upstream.

r0l1 commented 7 years ago

Any updates?

r0l1 commented 6 years ago

ping

filipochnik commented 6 years ago

It would be great to have this.