search

hashicorp / yamux

Golang connection multiplexing library
Mozilla Public License 2.0
2.25k stars 236 forks source link

don't block writes after session has shut down #46

Closed whyrusleeping closed 2 years ago

whyrusleeping commented 8 years ago

This should address the issues in #45 . I've applied this to my machine thats been able to semi-reliably reproduce the issue, so we'll see if it crops up again.

whyrusleeping commented 8 years ago

So far the issue hasnt come up again while running this code. Still watching...

whyrusleeping commented 8 years ago

Mmmm, thats interesting. Manages to get things hanging still even with this patch. I'll investigate more.

hashicorp-cla commented 5 years ago

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

evanphx commented 2 years ago

Given the age, I'm going to go ahead and close this PR.

evanphx commented 2 years ago

@whyrusleeping it's been a sec, but I do see where you're going with this.