search

hashicorp / yamux

Golang connection multiplexing library
Mozilla Public License 2.0
2.25k stars 236 forks source link

Missing commit in history #65

Closed alvin-huang closed 2 years ago

alvin-huang commented 6 years ago

This is in relation to https://github.com/hashicorp/nomad/issues/4455

I had a look at this today while I was on the hunt for dependency issues in our products.

Turns out the commit in question does exist and govendor fetch github.com/hashicorp/yamux@2658be15c5f05e76244154714161f17e3e77de2e works fine: https://github.com/hashicorp/yamux/commit/2658be15c5f05e76244154714161f17e3e77de2e

It came from this PR: (https://github.com/hashicorp/yamux/pull/53) which was merged and has a parent of: image

However, the trees for master: image

vs the tree for: https://github.com/hashicorp/yamux/commits/2658be15c5f05e76244154714161f17e3e77de2e

image

is different. Not sure what happened here but 683f491 and 3fc4056 are swapped in the two trees so all the hashes of the commits before them differ.

Hope this helps but I don't know the code base well enough to do surgery on it so I will leave it to the pros :). Looks like it might just be a rebase error.

cc: @preetapan @chelseakomlo @mkeeler

dgonzalezruiz commented 6 years ago

Could this please get some love?

evanphx commented 2 years ago

Given the age, I'm going to go ahead and close this.