search

hashicorp / yamux

Golang connection multiplexing library
Mozilla Public License 2.0
2.25k stars 236 forks source link

fix failing test #77

Closed pmalhaire closed 2 years ago

pmalhaire commented 5 years ago

fixing failing test in go 1.12 : see https://github.com/hashicorp/yamux/issues/71

19:15:03/Users/pierrot/dev/yamuxλ go test --count=1 ./...
2019/05/12 19:15:16 [ERR] yamux: keepalive failed: i/o deadline reached
--- FAIL: TestSendData_Large (0.40s)
    session_test.go:427: err: session shutdown
    session_test.go:396: err: EOF
2019/05/12 19:15:16 [WARN] yamux: failed to send ping reply: session shutdown
2019/05/12 19:15:24 [WARN] yamux: failed to send ping reply: connection write timeout
FAIL
FAIL    github.com/hashicorp/yamux  9.505s
19:15:25/Users/pierrot/dev/yamuxλ git checkout -
M   go.mod
Switched to branch 'fix_test'
Your branch is up-to-date with 'pmalhaire/fix_test'.
19:15:56/Users/pierrot/dev/yamuxλ go test --count=1 ./...
ok      github.com/hashicorp/yamux  9.911s
hashicorp-cla commented 5 years ago

CLA assistant check
All committers have signed the CLA.

jefferai commented 2 years ago

It's interesting that on a fresh checkout of yamux when running go test ./... I don't see this behavior. I wouldn't have expected cached behavior. But I do see it with -count=1 explicitly set.

Thanks for the fix!