search

hashids / hashids.github.io

This is the old Hashids website. It is no longer maintained and has migrated over to Sqids.
https://sqids.org
206 stars 34 forks source link

Lua implementation #33

Closed un-def closed 8 years ago

un-def commented 8 years ago

Hi there,

I'm maintainer of a hashids.lua fork. The hashids.org site now refers to original version of hashids.lua by leihog that is not compiled with Lua version > 5.1, has a few bugs and seems abandoned by author (I have tried to contact leihog via GitHub PR and email without success).

Is it possible to add/replace the Lua implementation link to my fork repo?

jd327 commented 8 years ago

Hi @un-def,

Thanks for the update. Have you tried submitting PRs with your bug fixes (not just contacting the author)? This might shine more light on the actual issues & encourage discussion. It looks like there's currently zero issues and no PRs for that repo.

If you don't get a response to those within a reasonable time, I'll ping Leif and we can see how to go about it. Thanks for taking the time to look at the original code.

cc @leihog

un-def commented 8 years ago

There is closed (by me) PR — https://github.com/leihog/hashids.lua/pull/1 I can open an issue if you think it will help to contact the author.

jd327 commented 8 years ago

Ah, I see. Yeah, it looks like it wasn't open for very long. I think you should re-open whatever PRs you have and give @leihog a bit more time to reply.

un-def commented 8 years ago

OK, I create another PR — https://github.com/leihog/hashids.lua/pull/2

jd327 commented 8 years ago

Thank you @un-def.

leihog commented 8 years ago

@ivanakimov thanks for pinging me. @un-def your mails are being classified as spam, I think google blocks all mails from yandex.ru which is why I didn't get your email. We'll continue the conversation on the PR itself.

jd327 commented 8 years ago

Cool. Looks like you guys have a conversation going on the PRs, so I'll close this issue.