hashids / hashids.github.io

This is the old Hashids website. It is no longer maintained and has migrated over to Sqids.
https://sqids.org
206 stars 34 forks source link

Kotlin version is worse than useless #41

Closed CorayThan closed 1 year ago

CorayThan commented 6 years ago

The Kotlin version is worse than useless. Looks like it was probably converted from Java a long time ago, before Kotlin reached 1.0, so it has many many compilation issues.

Anyone using this in Kotlin would be better off using the Java version. I would recommend removing the Kotlin one. Being published on Maven as a library is another big benefit of the Java version.

It looks like this ticket:

https://github.com/leprosus/kotlin-hashids/issues/2

Is an attempt to whole sale fix the many many issues it has, so if you don't want to remove the Kotlin version it at least needs to be fixed.

4kimov commented 1 year ago

Closing since the project is moving. @CorayThan let me know if you'd like to help out with https://sqids.org/kotlin