search

hashlips-lab / nft-erc721-collection

MIT License
446 stars 397 forks source link

Updating dependencies to support NodeJS 18 out-of-the-box #428

Closed liarco closed 1 year ago

sal-420 commented 1 year ago

@liarco I'm hoping you can provide some insight

  1. the change set displays the differences are to the contract yarn.lock and dapp yarn.lock. Both seem to have many package upgrades.
  2. is it possible that there are no script or coding differences
  3. how can a forked version apply the same change set
liarco commented 1 year ago

Hi @sal-420, this was simply a maintenance release so no changes have been made to the project code.

  1. I updated the dependencies and tested the code to make sure everything was still working as expected (couldn't spot any issues). By upgrading hardhat to the latest version we gained support to Node 18 (previous HH version was complaining about compatibility issues with Node 18 and people were getting stuck when following the tutorials). I also decided to stick to version 3.x for ERC721A to avoid any conflicts on the current stable version of this project, the next major version will probably use 4.x
  2. That's correct, no changes have been made to the code
  3. This depends on what has been done on the fork, if you didn't install any additional dependencies, then you can simply bring the same changes to your fork and it's gonna work fine. If you changed your dependencies (added/removed packages), then it really depends on your specific case and you should manage your dependencies manually (both the original and custom ones)