DEV:LOG:Log Curve Info for 1411 does not report class index correctly

[TessForGithub2]

For 1.4.1.1, this value is part of the log curve metadata.

Clarification: v1.4.1.1 has classIndex classIndex is present in the POJO & by design is set to 0; need to just place the correct value into this field instead of setting it to 0 (modification to Channel.java in df-395a).

[Mike-d-s]

Theresa, please revise this card and break it into two separate cards: (#460) one for for 1.4.1.1 which is part of the log curve metadata and (#454) one for for 1.3.1.1 which is the server side attribute specifying the order of the log curve in the data table by column count.

[TessForGithub2]

Update: I put in the fix and tested it (it looks fine). However, I want to perform the integration test, but "get channels" is reporting only classIndex (and not columnIndex). I will open a card for "get channels".

[Mike-d-s]

EPIC:

361 Log CRUD Implementation

[TessForGithub2]

Update: I did as Mike suggested & did a Postman test using DoT's version of Get Channels. I have an interesting situation where DoT is returning "classIndex" instead of "columnIndex" although, when I trace what I sent over, it is 1.3.1.1 and columnIndex. I will open a new card on this, since our Get Channels may not be the issue (I will alert Sukhe next). I also will perform another trace (but I did show Shehzad that I am sending in the payload for Channels what I think I should be sending...he was an extra pair of eyes to verify I was doing it correctly).

[TessForGithub2]

Update: DoT is fine, it was my understanding that was faulty. DoT only speaks "1.4.1.1". Drillflow performs all required conversions to speak "1.3.1.1" or "2.0". Cards updated to reflect this correction in thought.

[Mike-d-s]

Blocked waiting on fix from Sukhe. Additionally, needs to get valid test case from Shehzad.

[niaalex]

The fix is in and the team will address today in the merge. ETA 6/17.

[TessForGithub2]

UPDATE:

In Channel.java, 1 line of code needs to replace where classIndex is set to 0: lci.setClassIndex(c.getClassIndex());

Will put this fix in today (June 18).

[TessForGithub2]

Update: merged this fix into the master branch; due to release 7/11.

[TessForGithub2]

Update: for 1.4.1.1, is part of the log curve metadata Translation: -> from1411 (which gets WITSML XML from a v1.4.1.1 Client) just requires that is populated from log curve metadata (the "lci") - already in Master -> to1411 (which gets JSON from DoT) just requires that is populated from returned channel's - already in Master

Reopened this card to add documentation within the code base to be clear, and also clear up the language of this card.

Also, test via: AddToStore then the next step in the current test cases.

[niaalex]

Covered in the 395A Branch fix. ETA 7/22

[shehzadsidi]

Issue still exists, ClassIndex values are all 0

[TessForGithub2]

This is one I have already solved and is indf-395A. Will move it in quickly.

Theresa

On Tue, Sep 3, 2019, 11:19 AM Shehzad Sidi notifications@github.com wrote:

Issue still exists, ClassIndex values are all 0

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/hashmapinc/Drillflow/issues/460?email_source=notifications&email_token=ALOO7TLA3MIF4V5E3ALDBIDQH2FBDA5CNFSM4HS7MBT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5YX72I#issuecomment-527532009, or mute the thread https://github.com/notifications/unsubscribe-auth/ALOO7TLP4HXWRK44AHMHSWTQH2FBDANCNFSM4HS7MBTQ .