hashmapinc / Drillflow

A dockerized WITSML API Server that is agnostic of the backend.
Apache License 2.0
17 stars 13 forks source link

DEV:LOG: get from store does not return commonData #471

Closed Mike-d-s closed 5 years ago

Mike-d-s commented 5 years ago

Epic

361 Log CRUD implementation

Size: Medium

Bug: Perform the following query for a log.

<?xml version="1.0" encoding="UTF-8"?>
<logs xmlns="http://www.witsml.org/schemas/1series"     
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
    xsi:schemaLocation="http://www.witsml.org/schemas/1series  ../xsd_schemas/obj_log.xsd" 
    version="1.4.1.1">
    <log uidWell="Energistics-Well-0001" uidWellbore="Energistics-w1-wellbore-0001" uid="Test_depth_log2">
        <nameWell></nameWell>
        <nameWellbore></nameWellbore>
        <name></name>
        <commonData>
            <dTimCreation></dTimCreation>
            <dTimLastChange></dTimLastChange>
            <itemState></itemState>
            <comments></comments>
        </commonData>
    </log>
</logs>

Server return does not include commonData as requested , though common data was included when the log was created.

Return:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<logs version="1.4.1.1" xmlns="http://www.witsml.org/schemas/1series"
    xmlns:ns2="http://www.energistics.org/schemas/abstract">
<log uid="Test_depth_log2">
<nameWell>Well Energistics-well-0001</nameWell>
<nameWellbore>Wellbore Energistics-w1-wellbore-0001</nameWellbore>
<name>Test_depth_log2</name>
</log>
</logs>

Expected result: commonData should have been returned

sukhendumukherjee commented 5 years ago

When we added common data from AddToStore as below

2003-11-24T08:15:00.000Z 2003-11-24T08:15:00.000Z plan These are the comments associated with the log object.

We see response from DOT having itemState and comments.Not getting dTimCreation and dTimLastChange.From where we will get these values ?

niaalex commented 5 years ago

The PR for this one will be done today. @sukhendumukherjee will update this today. New ETA TBD

sukhendumukherjee commented 5 years ago

Currently we are getting itemState , dTimCreation and comments from DOT and now it’s added in common data and deployed in QA.We are not getting dTimLastChange from DOT and I have created a card df-517 to address that.