hashmapinc / Drillflow

A dockerized WITSML API Server that is agnostic of the backend.
Apache License 2.0
17 stars 13 forks source link

Create an Object Interface in the WitsmlObjects library and replace the StoreObject wrapper class in drillflow with that. #71

Closed randypitcherii closed 5 years ago

randypitcherii commented 5 years ago

This is tech debt from issue #41

This requires a touch of domain knowledge to align on what functionality should be implemented in the interface. This should allow general witsml "objects" to be treated the same in most of drillflow before type-specific logic is needed based on the object type.

Because the current Drillflow scope only includes 4 objects (Well, Wellbore, Trajectory, and Log), a wrapper class seemed like a suitable usage of technical debt to make progress quickly. This approach will become unduly verbose if we add another 5, 10, or 20 object types to the scope.

randypitcherii commented 5 years ago

An abstract class makes more sense for this.

randypitcherii commented 5 years ago

Finished abstract class implementation in WitsmlObjects library version 1.1.1

This branch won't build properly until the 1.1.1 jar is deployed in maven central. You'd have to pull the 1.1.1 branch and run mvn install to build locally until then.