Open nicorikken opened 7 years ago
I hope somebody will take a look at this PR, as it feels like a significant milestone to me.
Hi Nico! Sorry for the slow responses lately. I'm trying to ramp back up on Perun after an unplanned break due to starting a new job. I'd like to get a handle on your asciidoctor PR's so that we can get them merged, but I'm a bit confused on where I should start to get an overall idea of what's going on. Can you point me in a direction?
Hi, @nicorikken! Still working on this? What do you think about @podviaznikov's suggestion?
Enables
asciidoctor-diagram
support for generating images as defined inline in the source file. The resulting images are captured afterwards in a new task namedcollect-images
, to stick to the basic content-task structure for the base asciidoctor task.Previous code was refactored to have stronger defaults for options and metadata handling.
Based on the previous PR's https://github.com/hashobject/perun/pull/191 and https://github.com/hashobject/perun/pull/193
I'm very interested to hear your comments on this work:
collect-images
task the right way to collect images after thecontent-task
function?asciidoctor*
now has a global switch ondiagram
to determine whether or notasciidoctor-diagram
is enabled. Is this correct?permalink
task so the relative URL remains the same? Another way would be to fix this upfront, by giving each post it's own directory or by changing the relative URL namedimagesdir
in asciidoctor terminology.At the moment of writing you can observe the potential output at http://site.nicorikken.eu/posts/2017-08-14-testpost.html which is based on the source https://github.com/nicorikken/nicorikken.github.io/tree/perun which uses the code of this PR.