search

hashobject / perun

Programmable static site generator built with Clojure and Boot (HELP NEEDED!)
https://perun.io
Eclipse Public License 1.0
351 stars 38 forks source link

Fix support for Java 11 #223

Closed jaidetree closed 5 years ago

jaidetree commented 5 years ago

Updates

Docker Compose

  1. Run docker-compose run perun-java11
  2. It will attempt to build the image and then the blog example.

If it fails

  1. Make changes to the perun source
  2. Run docker-compose run perun-java11 bash
  3. Run cd /usr/src/perun
  4. Run boot install
  5. Run cd /usr/src/app
  6. Run boot build to rebuild the blog with updated perun lib

I'm hoping we can use the docker compose file to organize other builds for testing purposes as cases increase.

jaidetree commented 5 years ago

Fixes hashobject/perun.io#28

allentiak commented 5 years ago

@bhagany @podviaznikov Would it be OK merging this?

@eccentric-j Thanks for the fix! On the other hand, I'm not so sure whether it is convenient to publish a fork you don't seem to intend to maintain... If people start using it, you will have the pressure to keep it up to date... Two published packages may mean two packages to keep up to date... (Just a thought, though.)

jaidetree commented 5 years ago

I needed something up earlier so I could get fixes in a circle-ci build. My plan is to kill my fork when these changes are merged but at this point it's got two compatibility fixes so it is maintained.

podviaznikov commented 5 years ago

I think code looks good. I want to test it. Will do it today. Thank you for PR and discussion here.

jaidetree commented 5 years ago

@podviaznikov Thanks! Please let me know if anything comes up in your tests.

podviaznikov commented 5 years ago

@eccentric-j I think all looks good. The only thing is that atom plugin didn't render anything for blog example: perun-java11_1 | [atom-feed] - atom-feed found nothing to render. But maybe it was broken before. Will need to investigate. Otherwise lets merge!

Thank you for this!

jaidetree commented 5 years ago

Great 👍 I looked into the atom feed, I think it's because examples/blog/build.boot is:

        (perun/atom-feed :filterer :original)

https://github.com/hashobject/perun/blob/master/examples/blog/build.boot#L48

But the example posts don't have :original true in their yaml headers so it doesn't output anything.

podviaznikov commented 5 years ago

@eccentric-j thank for investigating. So it's something to look deeper. :original true should be set automatically. So some other bug I guess