search

hashobject / perun

Programmable static site generator built with Clojure and Boot (HELP NEEDED!)
https://perun.io
Eclipse Public License 1.0
351 stars 38 forks source link

Gravatar link should be https #238

Closed arichiardi closed 4 years ago

arichiardi commented 5 years ago

Hello folks,

I am receiving:

aws-lambda-runtime-lumo.html:3 Mixed Content: The page at 'https://andrearichiardi.com/blog/posts/aws-lambda-runtime-lumo.html' was loaded over HTTPS, but requested an insecure image 'http://www.gravatar.com/avatar/708f9c347fce0493d929be88dbf70ea9'. This content should also be served over HTTPS.

From one of my blog posts and I was wondering if there is a way to set https to the gravatar link.

I have seen tests have http but could not find where to change it? Is it baked in their library?

I can provide a patch with a bit of guidance.

Thanks!

podviaznikov commented 5 years ago

Hi @arichiardi. Yes, you can provide patch.

Seems like it's here https://github.com/hashobject/perun/blob/master/src/io/perun/gravatar.clj#L7 and the library we use provides https support https://github.com/alesguzik/gravatar-clj/blob/master/src/gravatar/core.cljc#L16.

So you can switch it to https for everyone.

arichiardi commented 5 years ago

Cool thank you for your pointers! I will definitely do it.