Closed owenkellogg closed 2 years ago
Hey, Steven. Thanks for the PR! This looks good. We're still getting things setup for how we're going to handle contributions and the like, but your change should be the first community submission that we merge in.
@brianvh Do you guys have a Telegram group or something similar to collaborate?
Hi, Steven. Sorry for the delay in getting back to you. We've got a lot of balls in the air, with this new launch. I wanted to let you know that your PR hasn't fallen through the cracks. 😀
A couple of comments, based on your latest 2 commits:
carrot-pool
aren't intended for Continuous Deployment.If you'd like to fork the repo, and then make specific config and CI/CD alternations to your version, we think that's great. But, we need to keep the main carrot-pool
as clean and agnostic as we can, so that any member of the community can download it, and make there own deployable release, with whatever toolchain they're using.
I'd still like to merge in your config file path from ENV commit, but I'd need you to remove the additional commits, which we won't be merging. Thanks! And please keep submitting PRs, or opening Issues for things you'd like to see changed, fixed, or added. We love the feedback and contributions.
This makes it easier to put configuration in a linux-standard place, or to link config files in via a docker container volume.