Handling pid from Webmock, tracking proxied requests, CORS

DavidMikeSimon commented 7 years ago

(This PR was moved from #17)

So I started out thinking "I really wish I could see which requests were proxied from within my capybara specs", and ended up with this PR, which rewrites large portions of capybara-webmock.

This is definitely a doozy, but I think I have a good reason behind each change I made:

Because I want to capture stdout from the process in a controlled way, I replaced IO.popen with Popen3.
Popen3 also happens to let me easily access the PID of the spawned process, which lets me move the pidfile logic out of Proxy and into Webmock, and simplify it a little.
While I was at it, I also made the pidfile recovery a little more tolerant of dead pidfiles; in the original implementation, the Process.kill('HUP', rack_pid) line would crash if the given PID was no longer running.
Additionally, I let the kill mechanism wait a bit for the HUP to kick in before it tries to start the new server, to avoid port conflicts. If the HUP doesn't work, it tries a KILL signal.
In the README, I've suggested calling start before each example instead of before the whole suite. This is needed to reset the list of proxied requests between each example. It's safely idempotent, start will not start a new process if it already has one running. Existing code that calls start in before(:suite) should also continue working as before.
Oh, also, the chrome_switches argument seems to be deprecated. The current way that works for me is to put args in desiredCapabilities. See https://sites.google.com/a/chromium.org/chromedriver/capabilities

Please let me know if you are interested in merging any of these changes back into the main branch, and if there's anything I can do to bring this code up to your standards. And, thank you for creating the wonderful and helpful tool capybara-webmock. :-)

DavidMikeSimon commented 7 years ago

Update: I also added some CORS headers to mocked responses so that non-GET requests to external domains can be mocked

dillonhafer commented 7 years ago

Thanks again for all this ❤️ we are still going to look over the changes (and mostly likely merge them), it's just going to take us a few days.

hashrocketeer commented 6 years ago

Closing this PR; we've merged most of the changes in via #29 and released as v0.5.0. Thank you! :heart: 🎉

DavidMikeSimon commented 6 years ago

@hashrocketeer Awesome! Thank you! 😁

hashrocket / capybara-webmock

Handling pid from Webmock, tracking proxied requests, CORS #18