hashrocket / capybara-webmock

Mock external requests for Capybara JavaScript drivers
MIT License
51 stars 19 forks source link

Run tests with GitHub actions to ensure gem works with more versions of Ruby #38

Closed singhprd closed 3 years ago

singhprd commented 3 years ago

Hey there hashrocketeers! 🚀 👋

We've been using capybara-webmock and are currently upgrading our app to Ruby 3, but there are just a couple of things that are stopping it running on Ruby 3.

I've authored a quick PR here (https://github.com/hashrocket/capybara-webmock/pull/39) that fixes the issues if you're still welcoming contributions 👍

As part of that, I've also used GitHub actions for running the tests, and ensuring the tests pass on more versions of Ruby, which is relatively easy using the GitHub actions matrix feature.

Here is that PR for migrating the CI system, if you're interested. GitHub actions makes things a little more open for outside contributions and allows testing against multiple Ruby versions so I think it's a nice use case, but up to you if you'd like to go for it 🙂

Cheers! Peter


Changes

For the maintainer from hashrocket, I think you'll need to approve the action before it'll run, as it's come from a fork 👍